Exceptions must be thrown
ID: csharp-best-practices/exception-must-be-thrown
Language: C#
Severity: Warning
Category: Best Practices
Exceptions should be thrown and not just created. An expression such as new Exception(...) does not throw the exception. You should use the keyword throw to throw the exception`.
using System.Xml;
class MyClass {
public void myMethod()
{
var a = new MyException("something bad happened");
}
}
using System.Xml;
class MyClass {
public void myMethod()
{
var bla = new MyClass("something bad happened");
}
public void foo() {
Formatter formatter = language switch
{
SqlLanguage.Sql => new StandardSqlFormatter(),
SqlLanguage.Tsql => new TSqlFormatter(),
SqlLanguage.Spark => new SparkSqlFormatter(),
SqlLanguage.RedShift => new RedshiftFormatter(),
SqlLanguage.PostgreSql => new PostgreSqlFormatter(),
SqlLanguage.PlSql => new PlSqlFormatter(),
SqlLanguage.N1ql => new N1qlFormatter(),
SqlLanguage.MySql => new MySqlFormatter(),
SqlLanguage.MariaDb => new MariaDbFormatter(),
SqlLanguage.Db2 => new Db2Formatter(),
_ => throw new NotSupportedException(),
};
}
}
using System.Xml;
class MyClass {
public void myMethod()
{
throw new MyException("something bad happened");
}
}
