Test assertions for booleans can be simplified
ID: java-best-practices/simplify-test-assertions-boolean
Language: Java
Severity: Notice
Category: Best Practices
Test assertions can be made more concise through the utilization of a more specialized assertion method.
This rule checks for a not operator (!
) in assertTrue
or assertFalse
methods and suggests replacing the operator with the assertTrue
or assertFalse
method.
This enhances the error message clarity and improves the overall readability of the assertion for other developers.
import org.junit.Test;
import static org.junit.Assert.*;
class Foo {
Object a,b;
@Test
void testFoo() {
assertTrue(!something); // could be assertFalse(something);
assertFalse(!something); // could be assertTrue(something);
}
}
import org.junit.Test;
import static org.junit.Assert.*;
class Foo {
Object a,b;
@Test
void testFoo() {
assertFalse(something);
assertTrue(something);
}
}