Prevent LDAP injection

Docs > Datadog Security > Code Security > Static Code Analysis (SAST) > SAST Rules > Prevent LDAP injection

Metadata

ID: python-flask/ldap-injection

Language: Python

Severity: Error

Category: Security

CWE: 90

Description

LDAP queries that use unsanitized inputs might allow attackers to inject unwanted elements into the query, allowing attackers to read or modify sensitive data, run code, and perform other unwanted actions.

Non-Compliant Code Examples

from flask import Flask, request

app = Flask(__name__)

@app.route("/login", methods=["POST"])
def login():
    data = request.get_json()
    username = data.get("username", "")
    password = data.get("password", "")

    # Not compliant
    ldap_filter = f"(&(uid={username})(userPassword={password}))"

    return f"Filter: {ldap_filter}"

Compliant Code Examples

from flask import request
import ldap

app = Flask(__name__)

@app.route("/login", methods=["POST"])
def login():
    data = request.get_json()
    username = ldap.filter.escape_filter_chars(data.get("username", ""))
    password = ldap.filter.escape_filter_chars(data.get("password", ""))

    ldap_filter = f"(&(uid={username})(userPassword={password}))"

    return f"Filter: {ldap_filter}"