when an if condition returns an value, else is not necessary

Metadata

ID: python-best-practices/if-return-no-else

Language: Python

Severity: Notice

Category: Best Practices

If the code in the if branch returns a value, do not have the else branch present.

if bla:
	foo()
	return 1
else:  # unnecessary, remove the else branch
	return 2

if bla:
	foo()
	return 1
elif bar:
	return 2

if bla:
	foo()
	return 1
return 2

if bla:
	foo()
else:
	return 2

1
2
rulesets:
  - python-best-practices     # Rules to enforce Python best practices.

Create a static-analysis.datadog.yml with the content above at the root of your repository
Use our free IDE Plugins or add Code Analysis scans to your CI pipelines
Get feedback on your code

For more information, please read the Code Analysis documentation

Identify code vulnerabilities directly in your
VS Code editor

Identify code vulnerabilities directly in
JetBrains products