ToString() should never return `null`

Metadata

ID: csharp-best-practices/tostring-not-return-null

Language: C#

Severity: Warning

Category: Error Prone

Description

The method ToString() should always return a value (for example, a string) and never return null. Instead of returning null, return string.Empty, which is an empty string.

Non-Compliant Code Examples

class MyClass {
    public override string ToString()
    {
        if(foo) {
            return null;
        }
        return null;
        
    }
}
class MyClass {
    public override string ToString()
    {
        return null;
    }
}

Compliant Code Examples

class MyClass {
    public override string ToString()
    {
        return string.Empty;;    
    }
}
https://static.datadoghq.com/static/images/logos/github_avatar.svg https://static.datadoghq.com/static/images/logos/vscode_avatar.svg jetbrains

Seamless integrations. Try Datadog Code Analysis

PREVIEWING: safchain/fix-custom-agent