API

HostnameVerifier should check certificates

Docs > Code Analysis > Static Analysis Rules > HostnameVerifier should check certificates

Metadata

ID: java-security/hostname-verifier-true

Language: Java

Severity: Error

Category: Security

CWE: 295

Description

A HostnameVerifier implementation should never just return true.

Learn More

Non-Compliant Code Examples

public class AllHosts implements HostnameVerifier {
    public boolean verify(final String hostname, final SSLSession session) {
        return true;
    }
}

Compliant Code Examples

public class AllHosts implements HostnameVerifier {
    public boolean verify(final String hostname, final SSLSession session) {
        if(isValidCertificate) {
            return true;
        }
        return false;
    }
}

How to use this rule

1
2
rulesets:
  - java-security     # Rules to enforce Java security.

Create a static-analysis.datadog.yml with the content above at the root of your repository
Use our free IDE Plugins or add Code Analysis scans to your CI pipelines
Get feedback on your code

For more information, please read the Code Analysis documentation

VS Code Extension

Identify code vulnerabilities directly in your
VS Code editor

JetBrains Plugin

Identify code vulnerabilities directly in
JetBrains products