API

Use Contains to check if a string contains something

Docs > Code Analysis > Static Analysis Rules > Use Contains to check if a string contains something

Metadata

ID: csharp-best-practices/indexof-contains

Language: C#

Severity: Info

Category: Best Practices

Description

To check is a string contains a sub-string, use Contains() and do not use proxy functions such as IndexOf.

Non-Compliant Code Examples

class MyClass {
    public static void processString(string s)
    {
        if(strings.IndexOf(s) == -1) {
            // do something
        }

        if(strings.IndexOf(s) < 0) {
            // do something else
        }

        if(strings.IndexOf(s) >= 0) {
            // or do this
        }
    }
}

Compliant Code Examples

class MyClass {
    public static void processString(string s)
    {
        if(!strings.Contains(s)) {
            // do something
        }
    }
}

How to use this rule

1
2
rulesets:
  - csharp-best-practices     # Rules to enforce C# best practices.

Create a static-analysis.datadog.yml with the content above at the root of your repository
Use our free IDE Plugins or add Code Analysis scans to your CI pipelines
Get feedback on your code

For more information, please read the Code Analysis documentation

VS Code Extension

Identify code vulnerabilities directly in your
VS Code editor

JetBrains Plugin

Identify code vulnerabilities directly in
JetBrains products