Avoid empty critical sections

Metadata

ID: go-best-practices/avoid-empty-critical-sections

Language: Go

Severity: Info

Category: Best Practices

Empty critical sections are often a mistake. Instead of unlocking, developers often miss using defer to defer unlocking the mutex.

func test() {
    mutex.Lock()
    mutex.Unlock()
}

func test() {
    mutex.Lock()
    doSomething()
    mutex.Unlock()
}

1
2
rulesets:
  - go-best-practices     # Rules to enforce Go best practices.

Create a static-analysis.datadog.yml with the content above at the root of your repository
Use our free IDE Plugins or add Code Analysis scans to your CI pipelines
Get feedback on your code

For more information, please read the Code Analysis documentation

Identify code vulnerabilities directly in your
VS Code editor

Identify code vulnerabilities directly in
JetBrains products