if conditions must have different code blocks

Metadata

ID: python-best-practices/condition-similar-block

Language: Python

Severity: Warning

Category: Best Practices

Description

Code in the branches of an if condition must be unique. If you have duplicated branches, merge the conditions.

Non-Compliant Code Examples

if foo:
  printf("bar")
elif baz:
  printf("bar2")
elif bap:
  # same code than the if condition
  printf("bar")
else:
  # same code than the if condition
  printf("bar")

Compliant Code Examples

if foo:
  printf("bar")
elif baz:
  printf("bar2")
elif bap:
  printf("bar3")
else:
  printf("bar4")
https://static.datadoghq.com/static/images/logos/github_avatar.svg https://static.datadoghq.com/static/images/logos/vscode_avatar.svg jetbrains

Seamless integrations. Try Datadog Code Analysis

PREVIEWING: rtrieu/product-analytics-ui-changes